Cache locales to avoid allocations #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electroid
previously approved these changes
Jan 7, 2022
|
@Pablete1234 LGTM. Mind fixing the formatting? |
Signed-off-by: Pablete1234 <[email protected]>
Pablete1234
force-pushed
the
locale-allocation-fix
branch
from
84d7020 to
9cbf3db
Compare
|
had ran the formatter on core instead of in the root PGM, and this was in util 😅 , should be good to go now |
Electroid
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseLocalecreates a new locale, and that internally calls intern for al lthe strings. it takes a significant hit in translating stuff and is the majority of the cpu time taken for scoreboard rendering.This is a profile where you can see the overall time to render the scoreboard, and highlighted in red how long parsing locales takes, most of it being String#intern called on the locale allocation. The 2 columns correspond to
translateLegacyandrenderGoalcalls respectively